Mark M. Hoffman wrote: > Hi: > > * author at mordac.netroedge.com <author at mordac.netroedge.com> [2005-03-26 18:22:10 -0800]: > >>Update of /home/cvs/lm_sensors2/kernel/busses >>In directory mordac.netroedge.com:/tmp/cvs-serv31041 >> >>Modified Files: >> i2c-ali1535.c >>Log Message: >>(mds) add delay loops everywhere, as recommended by the ALI 1535 Bios Programming Guide. >> Should fix stability problems. >> Patch by Ubel Walter <ubel at heidenhain.de> > > > The patch has a lot of noise, but... > > Picking a random port for the delay loop might not always be safe. > You should at least [request|release]_region() on it. > > Regards, > thanks for the comment. The port is specified in the ALI doc so I assume it's safe. It could be in the middle of some other driver's region so I didn't want to request_region() it. But Ubel may be able to check that. mds
