Winbond W83792D driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear MDS

> I have seen some  of your  mails  blocked on the mailing list but
received
> at  my address; you should _not_ use html mail or it will get blocked.

Yes, Jean also told me about it at 2004-11-18, after that I sent all
most all
my posts by "Plain Text" format, except I made a mistake by accident.
:-(

> I tested and checked-in your 4-line fix.
> In the future please provide a real patch generated by 'diff -u'.

I can see the changes in the lm_sensors CVS now, thanks.
I did not send you a patch this time because the modification is too
little,
I will send you patch next time when I modify the driver.

> I reviewed the datasheet  about comparator/interrupt modes.
> Unfortunately, only the temps support comparator mode; voltages and
fans
> support only interrupt  mode (datasheet sections 7.7.5-7.7.7)
> Please feed back our disappointment to your
> chip designers. I've never seen a hardware sensor that didn't support
> comparator mode.
> Comparator mode is our driver standard  as it is the most reliable for
the
> reasons I've previously mentioned. Without comparator  mode, we really
need
> an interrupt-driven driver or  the additional logic you've put into
'sensors'.

OK, I will discuss with our hardware designer about it, then give you
the
answer.


> My recommendation is that we set the temperature sensors to comparator
mode.
> The code at line 729 should put bits 7 and 6 of reg. 0x4C to 00
(comparator
> mode),
> which is what the comment says, but it sets it to 01 (2 times
interrupt mode).
> This is probably left over from whatever driver you copied from.
> So my recommendation is to set  the bits to 00.

Hmm, I will consider your recommendation carefully, then send you the
patch
if I modified the driver. I will send you mails again when I want to
discuss
with you about it. :-)


Thanks
Best Regards
Chunhao


===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original author of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such person, please kindly reply the sender indicating accordingly and delete all copies of it from your computer and network server immediately. We thank you for your cooperation. It is advisable that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email that does not relate to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message. They essentially repea!
 t the  English statement above.???H???????t?????q?l???]???????K?????T, ?????v???o?H?H???w?????H?H???\????. ?????z???D?Q???w?????H?H???]???????]?b???g???v?????????U???????H??, ???z?i?????o?H?H?????Y?N?H???q?q???P???????A???????H????. ?????z???X?@, ?????????P??. ?S??????, ???????g???v?????????????q?l?????K???T???????O?Q?Y???T????. ?H???P?????q?l???~?L???????e,???o?????????q?l?????????N??.



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux