RFC PATCH add set_value locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Lucky last: it87
> 
> I'm commenting on the second version of the patch.
> (...)
> Rest looks OK to me.

Ooops, missed this:

> -		it87_write_value(client, IT87_REG_PWM(nr), PWM_TO_REG(data->manual_pwm_ctl[nr]));
> +		it87_write_value(client, IT87_REG_PWM(nr),
> +				PWM_TO_REG(data->manual_pwm_ctl[nr]));

Don't do that, it doesn't belong there.

Thanks,
-- 
Jean Delvare



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux