Hi MDS, Jean Quoting myself: > When I test the "hardware-level" alarm mechanism of my chip w83627thf, I find > that when the voltage measured value below the low limit value, the "ALARM" > appears, buy this "ALARM" ONLY appears once, then it will disappear. > so do my new 792 driver. The reason is that the corresponding bit to the "ALARM" > recover from "1" to "0" automatically by itself. I finished fixing the point 1 "alarms" and point 3 "fan speeds in /proc" MDS provided me, and tested it briefly. But I don't think the "hardware-level" alarm mechanism is better than "software-level", besides the above reason, I also find such phenomenon: Step 1: #sensors: VCoreA: +1.47 V (min = +1.40 V, max = +1.60 V) Step 2: modify the low limit into 1.5V, then run #sensors -s: Step 3: VCoreA: +1.47 V (min = +1.50 V, max = +1.60 V) ALARM Step 4: VCoreA: +1.47 V (min = +1.50 V, max = +1.60 V) The ALARM will disappear when run "sensors" again, although the measured value is larger than low limit. Same as when I mentioned above Step 5: When I modify the low limit back from 1.5 V into 1.4V, run #sensors -s, Then run #sensors, I find the "ALARM" appears again, while the measured value is between the limits at this time: VCoreA: +1.47 V (min = +1.40 V, max = +1.60 V) ALARM It's not reasonable, don't you think so? My another question is: There are 4 files which have been modified by me this time: kernel/chips/w83792d.c lib/chips.c lib/chips.h prog/sensors/chips.c Since I can NOT access lm_sensors CVS here, If I need to commit them, Need I generate another patch to lm_sensors-2.9.0, and send the patch to you? Or just you the above 4 files? Thanks Best Regards Chunhao > -----Original Message----- > From: PI14 HUANG0 > Sent: 2005??3??16?? 13:26 > To: 'Mark Studebaker'; 'Jean Delvare' > Cc: sensors at Stimpy.netroedge.com; PI10 LHHsu; PI14 DZSHEN > Subject: RE: w83792d_driver-1.0.1.patch: Winbond W83792D driver for linux-2.4 > (patch to lm_sensors-2.9.0) > > Hi MDS > > > yes, "hardware-level" is much better, for the reasons I mentioned above. > > please change it when you have time. > > When I test the "hardware-level" alarm mechanism of my chip w83627thf, I find > that when the voltage measured value below the low limit value, the "ALARM" > appears, buy this "ALARM" ONLY appears once, then it will disappear. > so do my new 792 driver. The reason is that the corresponding bit to the "ALARM" > recover from "1" to "0" automatically by itself. > > Do you think this method is normal? I think the "ALARM" message should always > appears until the measured value is between the low/high limits, just like my > 792 driver in lm_sensors CVS. > > Btw, Is there any method for us to show "ALARM" all the time by "hardware-level" > alarm mechanism? > > Thanks > Best Regards > Chunhao > > > -----Original Message----- > > From: Mark Studebaker [mailto:mds at mds.gotdns.com] > > Sent: 2005??3??16?? 12:28 > > To: PI14 HUANG0 > > Cc: sensors at Stimpy.netroedge.com; PI10 LHHsu; PI14 DZSHEN > > Subject: Re: w83792d_driver-1.0.1.patch: Winbond W83792D driver for > linux-2.4 > > (patch to lm_sensors-2.9.0) > > > > Huang0 at Winbond.com.tw wrote: > > > Hi MDS > > > > > > Yes, I can get the file you provided, but since I have started the > > modifications, > > > I will use the one from web CVS, after deleting the line numbers, it is > same > > as > > > the one you provided, I compared them with "diff" :-) > > > > > > I have one question here: > > > I add W83792D_ALARM_* into 792 driver like this: > > > (please refer to the data sheet) > > > #define W83792D_ALARM_IN0 0x0001 > > > #define W83792D_ALARM_IN1 0x0002 > > > #define W83792D_ALARM_TEMP1 0x0004 > > > #define W83792D_ALARM_TEMP2 0x0008 > > > #define W83792D_ALARM_TEMP3 0x0010 > > > #define W83792D_ALARM_FAN1 0x0020 > > > #define W83792D_ALARM_FAN2 0x0040 > > > #define W83792D_ALARM_FAN3 0x0080 > > > #define W83792D_ALARM_IN2 0x0100 > > > #define W83792D_ALARM_IN3 0x0200 > > > #define W83792D_ALARM_IN4 0x0400 > > > #define W83792D_ALARM_IN5 0x0800 > > > #define W83792D_ALARM_IN6 0x1000 > > > #define W83792D_ALARM_CHAS 0x2000 > > > #define W83792D_ALARM_FAN7 0x8000 > > > #define W83792D_ALARM_IN7 0x80000 > > > #define W83792D_ALARM_IN8 0x100000 > > > #define W83792D_ALARM_FAN4 0x200000 > > > #define W83792D_ALARM_FAN5 0x400000 > > > #define W83792D_ALARM_FAN6 0x800000 > > > > > > Can I replace the last 6 items with ? > > > #define W83792D_ALARM_FAN7 0x4000 > > > #define W83792D_ALARM_IN7 0x8000 > > > #define W83792D_ALARM_IN8 0x10000 > > > #define W83792D_ALARM_FAN4 0x20000 > > > #define W83792D_ALARM_FAN5 0x40000 > > > #define W83792D_ALARM_FAN6 0x80000 > > > > > > With one is better? The first one or the latter? > > > Are them same? > > > > > > > > > Thanks > > > Best Regards > > > > > > Chunhao > > > > the easiest is to form the alarms word directly from the three registers: > > pseudocode below > > alarms=read(0x41) | (read(0x42) << 8) | (read(0x9b) << 16) > > so the first one is better. ===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original author of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such person, please kindly reply the sender indicating accordingly and delete all copies of it from your computer and network server immediately. We thank you for your cooperation. It is advisable that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email that does not relate to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message. They essentially repea! t the English statement above.???H???????t?????q?l???]???????K?????T, ?????v???o?H?H???w?????H?H???\????. ?????z???D?Q???w?????H?H???]???????]?b???g???v?????????U???????H??, ???z?i?????o?H?H?????Y?N?H???q?q???P???????A???????H????. ?????z???X?@, ?????????P??. ?S??????, ???????g???v?????????????q?l?????K???T???????O?Q?Y???T????. ?H???P?????q?l???~?L???????e,???o?????????q?l?????????N??.
