Hi Grant, all, > From an end-user perspective it is easy to miss the third Intel PIIX > entry on the menuconfig "I2C Hardware Bus support" screen. > Also the Intel 801 menu item does not mention ICH. > > This trivial patch groups three Intel entries together, adds ICH to > menu item, and ICH5/ICH5R to the help section. I'm all for it, as it makes full sense. I would simply suggest the following variations (I feel like nitpicking today): > config I2C_I801 > - tristate "Intel 801" > + tristate "Intel 801/ICH" I'd rather say "Intel 82801 (ICH)". It's an alternate name for the same thing, not two separate chips/families. >@@ -119,7 +119,7 @@ > 82801BA > 82801CA/CAM > 82801DB >- 82801EB >+ 82801EB/82801ER (ICH5/ICH5R) That would be /ER if you follow the example above. > +config I2C_PIIX4 > + tristate "Intel PIIX4" > + depends on I2C && PCI && EXPERIMENTAL While you are there, feel free to discard EXPERIMENTAL. The driver exists for maybe 6 years, if we don't consider it stable now, we never will. Care to repost a version of your patch including all suggested changes that you found relevant, it any? Note that you have to CC: Greg KH when posting such patches if you want him to include them in his tree and later push them to Andrew Morton. Thanks for your help, -- Jean Delvare
