Revised patch is attached.
Jean Delvare wrote:
> Hi James,
>
>
>>A revised ds1337 patch addressing all of Jean's comments is attached.
>
>
> Fine with me except for:
>
>
>>+ if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA |
>>+ I2C_FUNC_SMBUS_I2C_BLOCK))
>
>
> I don't this it is correct. You are using master_xfer, not
> i2c_smbus_{read,write}_i2c_block_data. Adapter which declare themselves
> I2C_FUNC_SMBUS_I2C_BLOCK-capable may not implement master_xfer. You
> really need to check for I2C_FUNC_I2C.
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ds1337.patch
Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050304/0be23434/attachment.pl
