Revised ds1337 chip driver patch. Signed-off-by: James Chapman <jchapman at katalix.com> - change all driver log messages to use dev_dbg() or dev_err() - remove debug module parameter Greg KH wrote: > On Mon, Feb 28, 2005 at 05:14:25PM +0000, James Chapman wrote: > >>+/* Define to compile in pr_debug() trace */ >>+#undef DEBUG > > > Not needed, we do this in the makefile now. > > >>+ if (debug >= 1) >>+ pr_debug("%s: client=%p, dt=%p\n", __FUNCTION__, client, dt); > > > Please use the dev_dbg(), dev_err() and friend functions instead of > pr_debug(). It provides a sane user interface that all of the other > drivers use. > > thanks, > > greg k-h -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: ds1337.patch Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050301/cdbdc5ae/attachment.pl