Hi Jean, MDS This is Chunhao. The following is my answer. > It is always possible to commit a first version and apply patches > afterwards as problems are found and fixed. We don't plan to release a > new version of lm_sensors before a couple of months, so it can be > committed now, get some testing by the few CVS users we have, get fixed > where needed and be ready for the next release. That would sound like a > sane timeline. > > I think we have a few users which have W83792D chips and are waiting for > a driver to test. I can't remember if these were running 2.4 or 2.6 > kernels though. At any rate, committing early will increase the chances > that your code gets additional testing, which is definitely good. Yeah, I agree with you, I will persuade my manager to commit the 792 driver as soon as possible. :-) But since my manager is taking the Chinese traditional new year vacation from this morning, I can NOT contact him for about 10 days. And my vacation also will start two days later.:-) We will back to work at Feb. 16. At that time I will contact you about it. Is that OKay? > What MDS is probably waiting for before adding your driver to lm_sensors > CVS is a patch to libsensors and sensors that would add support for the > w83792d chip type. End-users need this to really take benefit of your > driver. Reading the raw values from /proc isn't exactly convenient. As > a side effect, doing this should help you understand how voltage scaling > works and hopefully convince you that libsensors can handle voltage > conversions just right so your driver don't need to do that by itself ;) Do you mean that the patch to libsensors should be provided by me? Or MDS will write it? Besides w83792d.c, I also have finished the following files: (1) prog/sensors/main.c (2) prog/sensors/chips.h (3) prog/sensors/chips.c (4) lib/chips.h (5) lib/chips.c (6) kernel/chips/Module.mk I attached them in this email, please check them. it is for my colleague's test. You may refer to them so that you can know the work I have done. But I do NOT modify the /etc/sensors.conf because I'm not very familiar with it, maybe MDS can modify it for me ;-) Could you confirm that if I commit the 792 driver, which files should I provide? > See the "PWM" section of the document. It has standard file names and > values for both manual and hardware-controlled fan speed control. > Basically, pwmN_enable selects control mode (off, manual, automatic), > pwmN controls duty cycle in manual mode (and optionally displays current > duty cycle in automatic mode), the other files control the various trip > points in automatic mode. It might or might not fit the W83792D model. I > hope it does, because we had a hard time designing this interface so > that it would be suitable for all chips. If you need more than that, > just add the files you need. If it happens that more chip drivers need > the same, we'll attempt to standardize afterwards. > > The basic rule is that you shouldn't use a different name or different > value conventions for things that are already standardized - for the > rest you are relatively free, as long as your choices are consistent. OK, I see, thanks, I will pay more attention to Documentation/i2c/sysfs-interface at first, especially to the "PWM" section. Then I will contact you if I have more questions about it. :-) Thanks Best Regards Chunhao 2005-02-05 ===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original author of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such person, please kindly reply the sender indicating accordingly and delete all copies of it from your computer and network server immediately. We thank you for your cooperation. It is advisable that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email that does not relate to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message. They essentially repeat the English statement above.???H???????t?????q?l???]???????K?????T, ?????v???o?H?H???w?????H?H???\????. ?????z???D?Q???w?????H?H???]???????]?b???g???v?????????U???????H??, ???z?i?????o?H?H?????Y?N?H???q?q???P???????A???????H????. ?????z???X?@, ?????????P??. ?S??????, ???????g???v?????????????q?l?????K???T???????O?Q?Y???T????. ?H???P?????q?l???~?L???????e,???o?????????q?l?????????N??. -------------- next part -------------- A non-text attachment was scrubbed... Name: lm_sensors-2.9.0_792part.tar.gz Type: application/x-gzip Size: 77098 bytes Desc: lm_sensors-2.9.0_792part.tar.gz Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050205/c1acebeb/attachment.gz
