Jean Delvare wrote: >>+config I2C_MV64XXX >>+ tristate "Marvell mv64xxx I2C Controller" >>+ depends on I2C && MV64X60 >> >> > >&& EXPERIMENTAL? > Done. >>+#define I2C_ALGO_MV64XXX 0x170000 /* Marvell mv64xxx i2c ctlr */ >> >> > >0x170000 is reserved within the legacy i2c project for an USB algorithm, >and 0x180000 for virtual busses. Could you please use 0x190000 instead, >so as to avoid future collisions? > Done. > >+#define MV64XXX_I2C_CTLR_NAME "mv64xxx i2c" >+#define MV64XXX_I2C_OFFSET 0xc000 >+#define MV64XXX_I2C_REG_BLOCK_SIZE 0x0020 > > > >You have a tab instead of space before MV64XXX_I2C_CTLR_NAME, it seems. >Also, you want to align the numerical values using only tabs, no space. > > Actually, I did use tabs but what was already there used spaces. So the patch won't mess up the alignment, I changed mine to spaces too. The attached patch is a complete replacement for the one posted earlier. Signed-off-by: Mark A. Greer <mgreer at mvista.com> -- -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: i2c_2.patch Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050126/79a2ce16/attachment.pl
