Dear MDS This is Chunhao. Thank you for your suggestions to 792 driver. The following is my answer to your questions. > - I would like to understand the smart fan interface in /proc. > Do you have a preliminary document to be doc/chips/w83792d which describes > the interface? We would like to see that. I'm sorry that I do not have a preliminary document describes it, but I think it's NOT difficult to understand, if you connect datasheet 7.7.3/7.7.4 and the interfaces of fan_cfg, pwm_flag, pwm[1-3], thermal_cruise, fan_tolerance, sf2_levels_fan[1-3], and sf2_points_fan[1-3] in /proc.(^_^) And I'd like to give some comments here: (1) Since I finish this driver with the help of w83781d.c and 792 driver for Windows version(which has not be finished completely). All the interfaces of SmartFanI/II are the requirements of our customs. So I added it into 792 Linux driver. (2) As to the SmartFan, we only consider Fan1,Fan2 and Fan3, instead of all the Fans. I attached some GUI of Windows version, added the interfaces of /proc onto the GUI. Please refer to the attachments, especially the red color comments added by me. Then you will understand the usage of SmartFan interface. If you still have some questions about it, don't hesitate to mail us. > - The VID code looks wrong. The 792D has two VID registers that are different > than previous chips. En...I still do NOT understand the VID very well, Since our customs do NOT require us provide any function of VID, I'm going to delete thefunctions: w83792d_vid(), w83792d_vrm() and the interfaces vid and vrm in /proc. Do you have any disagreement or suggestions about it? > - In w83792d_in() the code does not handle writing only the low limit > (add "if nrels_mag > 2) .....") Yes, you are right, I have modified the codes, thanks. > - Why is the vol_factor array exposed to /proc? Isn't this only for debugging? > These shouldn't be exposed to the user. If the user needs to adjust > computation it can be done in /etc/sensors.conf. In the requirements of our customer: the motherboard vendor should have the permission to modify the voltage factor, so I expose it into /proc. I write it with the reference of our Windows version, the Windows version GUI supply a interface to modify the voltage factor, but it need authentication, That's to say, NOT all of the user can modify it. Btw, I have tested the 792 driver on the motherboard with P4 CPU, it works well, Now, I'm waiting for another motherboard for further test. After that, I will consider to check 792 related source files into CVS. And I will need your help at that time. For example, to add 792 related codes into the script program "sensors-detect" because I know very few about Perl. :-) Best Regards Chunhao > Huang0 at Winbond.com.tw wrote: > > OK, Thank you. > > I will wait for your suggestion. > > > > > > Best Regards > > Chunhao > > > > > > > >>-----Original Message----- > >>From: Mark Studebaker [mailto:mds4 at verizon.net] > >>Sent: 2005?1?18? 11:04 > >>To: PI14 HUANG0 > >>Cc: PI10 LHHsu; PI14 DZSHEN; sensors at Stimpy.netroedge.com > >>Subject: Re: Winbond 792 source codes for lm_sensor > >> > >>hi chunhao > >>sorry for delay > >>holidays and vacation > >>will review and respond soon :) > >>mds > >> > >>Huang0 at Winbond.com.tw wrote: > >> > >>>Hi MDS, Jean, and Mark > >>> > >>>This is chunhao. > >>> > >>>I have sent the w83792d driver source code and datasheet to you > >>>for about 20 days, But I have NOT get any comments till now. > >>> > >>>Did you review my codes? If you have some suggestions, > >>>Please don't hesitate to tell me. :-) > >>> > >>> > >>>Thanks > >>>Best Regards > >>> > >>>Chunhao > >>> > >>> > >>> > >>> > >>>>-----Original Message----- > >>>>From: Mark Studebaker [mailto:mds4 at verizon.net] > >>>>Sent: 2004?12?24? 01:03 > >>>>To: PI14 HUANG0 > >>>>Cc: PI10 LHHsu; PI14 DZSHEN; sensors at Stimpy.netroedge.com > >>>>Subject: Re: Winbond 792 source codes for lm_sensor > >>>> > >>>>chunhao, > >>>>we received both the datasheet and the code. > >>>>thank you very much. > >>>>I'm sure you'll receive comments soon. > >>>>mds > >>>> > >>>>Huang0 at Winbond.com.tw wrote: > >>>> > >>>> > >>>>>Hi MDS, Jean, and Mark > >>>>> > >>>>>This is chunhao. > >>>>> > >>>>>The 792 driver of trial version has been sent to you, > >>>>>Please check it, and please just me us a response if > >>>>>you get it. > >>>>> > >>>>>I'd like to add some comments to the 792 driver: > >>>>>1 The source is just a trial version, I will continue > >>>>>to modify it, so please don't add it into the cvs. > >>>>>And I will commit it by lm_sensors cvs, later, which > >>>>>maybe need your help. :-) > >>>>> > >>>>> > >>>>>2 The file sent to you is only one: w83792d.c > >>>>>I also modified the following files: > >>>>> 2.1 prog/sensors/main.c > >>>>> 2.2 prog/sensors/chips.h > >>>>> 2.3 prog/sensors/chips.c > >>>>> 2.4 lib/chips.h > >>>>> 2.5 lib/chips.c > >>>>> 2.6 lib/proc.c > >>>>>If you need refer to them, please tell me. > >>>>> > >>>>>3. some of the function are added by me in 792, maybe > >>>>>they do NOT exist in w83781d.c, I will write some > >>>>>documents to them when I release it in the future. > >>>>>For example: the following functions > >>>>>w83792d_thermal_cruise() > >>>>>w83792d_fan_tolerance() > >>>>>w83792d_sf2_points() > >>>>>w83792d_sf2_levels() > >>>>>w83792d_fan_cfg() > >>>>>have something to do with SmartFanI and SmartFanII > >>>>>mode. As to the SmartFan mode, you may refer to the 792 > >>>>>data sheet. > >>>>> > >>>>> > >>>>>4. If you find some bugs in the source, please don't > >>>>>hesitate to tell us, and you may also give me some other > >>>>>suggestions about it. > >>>>>:-) > >>>>> > >>>>>Btw, Do you have an available w83792d chip? If do, maybe > >>>>>you can do some simple test for me when you are free? > >>>>> > >>>>>Thanks > >>>>>Best Regards > >>>>> > >>>>> > >>>>>Chunhao > >>>>> > >>>>>________________________________________ > >>>>>From: PI14 DZSHEN > >>>>>Sent: 2004?12?23? 16:59 > >>>>>To: 'mds4 at verizon.net'; 'khali at linux-fr.org'; > 'mhoffman at lightlink.com'; > >>>> > >>>>'sensors at Stimpy.netroedge.com' > >>>> > >>>> > >>>>>Cc: PI14 HUANG0; PI10 LHHsu > >>>>>Subject: Winbond 792 source codes for lm_sensor > >>>>> > >>>>>Dear all: > >>>>> Per my manager?s request (Haoge, lhhsu at winbond.com.tw), I am sending > >>>>>this 792 source code. If you have any technical questions, please > >>>>>contact huang0 at winbond.com.tw. > >>>>> > >>>>>Best regards > >>>>> > >>>>>techeng > >>>>> > >>>>> > >>>> > >>>>====================================================================== > == > >> > >>== > >> > >>>>=================The privileged confidential information contained in > this > >>>>email is intended for use only by the addressees as indicated by the > original > >>>>author of this email. If you are not the addressee indicated in this email > >> > >>or > >> > >>>>are not responsible for delivery of the email to such person, please kindly > >>>>reply the sender indicating accordingly and delete all copies of it from > your > >>>>computer and network server immediately. We thank you for your cooperation. > >>>>It is advisable that any unauthorized use of confidential information of > >>>>Winbond is strictly prohibited; and any information in this email that does > >>>>not relate to the official business of Winbond shall be deemed as neither > >> > >>given > >> > >>>>nor endorsed by > >>>>Winbond.============================================================== > == > >> > >>== > >> > >>>>=========================If your computer is unable to decode Chinese > font, > >>>>please ignore the following message. They essentially repe > >>>>a! > >>>> > >>>> > >>>>>t the English statement above.????????????????? > ? > >>>> > >>>>?, ?????????????????. ???????????????? > ? > >> > >>? > >> > >>>>???????????????, ????????????????????? > ? > >> > >>? > >> > >>>>?????. ??????, ??????. ????, ????????????? > ? > >> > >>? > >> > >>>>??????????????. ??????????????,?????? > ? > >> > >>? > >> > >>>>??????. > >>>> > >>>> > >>> > >>> > >>======================================================================== > == > >>=================The privileged confidential information contained in this > >>email is intended for use only by the addressees as indicated by the original > >>author of this email. If you are not the addressee indicated in this email > or > >>are not responsible for delivery of the email to such person, please kindly > >>reply the sender indicating accordingly and delete all copies of it from your > >>computer and network server immediately. We thank you for your cooperation. > >>It is advisable that any unauthorized use of confidential information of > >>Winbond is strictly prohibited; and any information in this email that does > >>not relate to the official business of Winbond shall be deemed as neither > given > >>nor endorsed by > >>Winbond.================================================================ > == > >>=========================If your computer is unable to decode Chinese font, > >>please ignore the following message. They essentially repe > >>at the English statement > >>above.???H????t????q?l???]?????K???T, ????v??o?H?H??w?????H?H??\????. > ?? > >>??z??D?Q??w?????H?H??]????]?b???g???v????????U?????H??, ??z?i????o?H? > H? > >>??Y?N?H??q?q???P????A???????H??. ???z???X?@, ????P??. ?S??????, ????g??? > >>v????????q?l????K??T??? > >>??O?Q?Y??T??. ?H??P????q?l??~?L????e,???o?????q?l??????N??. > > > > > > > > > ========================================================================== > =================The privileged confidential information contained in this > email is intended for use only by the addressees as indicated by the original > author of this email. If you are not the addressee indicated in this email or > are not responsible for delivery of the email to such person, please kindly > reply the sender indicating accordingly and delete all copies of it from your > computer and network server immediately. We thank you for your cooperation. > It is advisable that any unauthorized use of confidential information of > Winbond is strictly prohibited; and any information in this email that does > not relate to the official business of Winbond shall be deemed as neither given > nor endorsed by > Winbond.================================================================== > =========================If your computer is unable to decode Chinese font, > please ignore the following message. They essentially repe > at the English statement > above.???H???t????q?l???]?????K???T, ????v??o?H?H??w?????H?H??\????. ?? > ??z??D?Q??w?????H?H??]????]?b???g???v????????U?????H??, ??z?i????o?H?H? > ??Y?N?H??q?q???P????A???????H??. ???z???X?@, ????P??. ?S??????, ???g??? > v????????q?l????K??T??? > ??O?Q?Y??T??. ?H??P????q?l??~?L????e,???o?????q?l??????N??. -------------- next part -------------- A non-text attachment was scrubbed... Name: smartfan_3.JPG Type: image/jpeg Size: 36394 bytes Desc: smartfan_3.JPG Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050124/ba3970b7/attachment.jpe -------------- next part -------------- A non-text attachment was scrubbed... Name: smartfan_1.JPG Type: image/jpeg Size: 36960 bytes Desc: smartfan_1.JPG Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050124/ba3970b7/attachment-0001.jpe -------------- next part -------------- A non-text attachment was scrubbed... Name: smartfan_2.JPG Type: image/jpeg Size: 34080 bytes Desc: smartfan_2.JPG Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20050124/ba3970b7/attachment-0002.jpe
