Hello Jean : I am the coordinator of 792 software program and appreciate your help with Chunhao. He noted me your requirement of Winbond 792 data sheet. The 792 chip approached to mass production state and have a draft release in attached. There are two revisions for 792/ The attsached file is C version. It is the major. Although the B version was shipped customers too. I will send the b version data sheet to you in near future. Thanks BR LH Hsu -----Original Message----- From: Jean Delvare [mailto:khali at linux-fr.org] Sent: Tuesday, December 21, 2004 4:38 PM To: PI14 HUANG0 Cc: LM Sensors; PI10 LHHsu; PI14 DZSHEN Subject: RE: New chip driver development plan to Lm_sensors Hi Chunhao, > Quoting Jean: > > No register read should happen outside of the update function > > (except in the init function when loading the driver, granted). > > But in kernel/chips/w83781d.c > I find that there are some "w83781d_read_value" in the following > functions: > w83781d_beep() > w83781d_fan_div() > w83781d_pwm() > w83781d_sens() > when these functions do the "write" operations, which are outside > the update function. > > So my questions are: > (1) Is it improper for w83781d to use "w83781d_read_value" in that > way? No, it is correct. My statement wasn't very clear. What must *not* be done is allow a regular user to generate I2C traffic outside of the update function (because we can use the cached values to skip repeated reads in the update function, but hardly outside). Using i2c reads for write operations is fine, because only root can run these write functions (and we assume root knows what he/she's doing). > (2) In w83792d.c, there are also many places where call the > w83792d_read_value() function outside w83792d_update_client() when > dealing with the "write" operation, which is similar with the above > situation in w83781d.c > Need I modify the source into using the member of struct w83792d_data? No, you don't need to modify your code. Thanks, -- Jean Delvare ===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original author of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such person, please kindly reply the sender indicating accordingly and delete all copies of it from your computer and network server immediately. We thank you for your cooperation. It is advisable that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email that does not relate to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message. They essentially repeat the English statement above.???H???????t?????q?l???]???????K?????T, ?????v???o?H?H???w?????H?H???\????. ?????z???D?Q???w?????H?H???]???????]?b???g???v?????????U???????H??, ???z?i?????o?H?H?????Y?N?H???q?q???P???????A???????H????. ?????z???X?@, ?????????P??. ?S??????, ???????g???v?????????????q?l?????K???T???????O?Q?Y???T????. ?H???P?????q?l???~?L???????e,???o?????????q?l?????????N??. -------------- next part -------------- A non-text attachment was scrubbed... Name: W83792D V0.83.pdf Type: application/octet-stream Size: 924366 bytes Desc: W83792D V0.83.pdf Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20041222/9de182f2/attachment.obj
