Hi Ian, > - printk(KERN_ERR DRIVER ": bus is not idle. status is %#04x\n", state ); > + DEB1(KERN_ERR DRIVER ": bus is not idle. status is %#04x\n", state ); Doesn't look OK to me. Either this is an error and it has to be displayed regardless of DEBUG being enabled or not, or it is a debugging info and it should use KERN_DEBUG instead of KERN_ERR. In the latter case, I can already hear Greg suggest you should use pr_debug or even dev_dbg instead of printk. (Otherwise I am fine with the I2C_FUNC_I2C additions, even if I did not look at the datasheets.) Thanks, -- Jean Delvare
