Hi Jean, MDS
I'm writing a new driver for w83792D, which is w83792d.c,using
w83781d.c as my reference, deleting the codes related with ISA except
two places, because 792D will only be on I2C.
But I have two questions about w83792d driver now.
(1) Can I delete the following codes?
static unsigned int normal_isa[] = { 0x0290, SENSORS_ISA_END };
static unsigned int normal_isa_range[] = { SENSORS_ISA_END };
I guess the above two sentences are useless, but I'm not very
sure about it's function, can you tell me whether I can delete
them or not?
(2) When you are free, can you give me some general explanation
of the member "last_updated" of struct w83792d_data?
What I need to do is just keep all the codes related with
"w83792d_data->last_updated" in w83781d.c
Is that right?
Thanks
Best Regards
Chunhao
-----Original Message-----
From: Jean Delvare [mailto:khali at linux-fr.org]
Sent: 2004??11??18?? 16:41
To: PI14 HUANG0; sensors at Stimpy.netroedge.com
Cc: PI10 LHHsu; PI14 DZSHEN; PI13 KSWang; PI13 CLHuang2
Subject: Re: New chip driver development plan to Lm_sensors
Quoting Mark D. Studebaker:
> If the 792 is a Super I/O chip, I strongly recommend that you start from
> our w83627hf.c driver rather than the w83781d.c driver. If it is i2c/isa,
> the w83781d.c driver is the best place to start.
>From previous reports from users, I suspect that the W83792D is not a
Super-I/O chip (the location it appears at on the Winbond website seems
to confirm that) but more likely an SMBus device, like the W83791D is.
In fact the 792D seems to be an evolution of the 791D. Of course a
datasheet for the 792D would help much. I guess that Huang can confirm
that, or tell me if I got it wrong?
As a side note, I noticed that the w83781d driver in Linux 2.6 doesn't
support the W83791D chip. Thus I would propose that Huang starts a new
driver for the W83792D, even if it is based of the w83781d.c code, and,
if the 791D and 792D are mostly compatible as I suspect, include support
for the 791D to the new driver, so that we can remove it from the
w83781d driver. This has two advantages:
1* Better symmetry between 2.4 and 2.6.
2* The new driver would be I2C only so cleaner and smaller.
Huang:
We never received your original post. It could have been caught by the
spam filter we run to protect the mailing-list. The best thing you can
do to ensure it won't happen with later posts is to avoid sending HTML
mails to the list. Plain test mails are way less likely to be mistaken
as spam.
Don't bother with a driver ID, they are more or less deprecated and
never used anyway. You can simply omit the .id field in the driver
structure.
Keep us informed of the evolution of your work, and let us know if you
have questions we can help with!
Thanks,
--
Jean
===========================================================================================The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original author of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such person, please kindly reply the sender indicating accordingly and delete all copies of it from your computer and network server immediately. We thank you for your cooperation. It is advisable that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email that does not relate to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond.===========================================================================================If your computer is unable to decode Chinese font, please ignore the following message. They essentially repea!
t the English statement above.???H???????t?????q?l???]???????K?????T, ?????v???o?H?H???w?????H?H???\????. ?????z???D?Q???w?????H?H???]???????]?b???g???v?????????U???????H??, ???z?i?????o?H?H?????Y?N?H???q?q???P???????A???????H????. ?????z???X?@, ?????????P??. ?S??????, ???????g???v?????????????q?l?????K???T???????O?Q?Y???T????. ?H???P?????q?l???~?L???????e,???o?????????q?l?????????N??.
