Hi Mark, On Thursday 08 July 2004 07:01, Mark M. Hoffman wrote: > Hi all: > > * Geoffrey Hausheer <c479wy002 at sneakemail.com> [2004-07-06 10:49:36 -0500]: > > On Tue, 6 Jul 2004 10:59:16 +0200, "Alexander Malysh amalysh-at-web.de > > > > |lm-sensors/1.0-Allow|" <ii2ui0fae60t at sneakemail.com> said: > > | > > > Hi, > > > > > > please try attached patch... > > (attached patch added SiS 1039:0018 to PCI device list of sis630.c) yep, that's correct... > > > > Thanks! > > > > Thanks, this did indeed work, though when running sensors-detect, i get: > > Next adapter: SMBus SIS630 adapter at 5080 (Algorithm unavailiable) > > Do you want to scan it? (YES/no/selectively): > > Client found at address 0x08 > > Client found at address 0x10 > > <snip> > > Well, that's interesting all by itself. Until now, I thought that > 1039:0018 were always just mis-identified SiS 96x south bridges. I've seen > a SiS735 (single-chip north/south) identify itself as 1039:0735 & > 1039:0018. For that system, the sis96x driver works fine. > > In your case, Geoffrey, the 2.6 kernel PCI quirks routine still does the > right thing (or at least, it doesn't break anything I guess). Trouble is, > it tries to write a particular bit in the PCI device config space that is > probably not appropriate... one that for 96x chipsets would enable the > SMBus device. I'm not sure what to do about this. sis630/sis730 LPC has also a ability to change a id, so PCI quirk routine just did this and i2c-sis630 should be aware of this possibility. > > Furthermore, what happens when the guy with 1039:0735/1039:0018 loads > sis630? That could be very bad. nothing bad will happens, as long the guy doesn't force i2c-sis630 to be loaded, because i2c-sis630 checks for supported chips (and those are: sis630, sis730). > > Regards, -- Best regards, Dipl.-Ing. Alexander Malysh -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: signature Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20040708/522f90e2/attachment.bin
