Hi, i2c_add_driver() may actually fail, but this driver returns 0 regardless. Against 2.6.7. Thanks. Signed-off-by: Arthur Othieno <a.othieno at bluewin.ch> msp3400.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) --- a/drivers/media/video/msp3400.c 2004-06-17 17:29:45.000000000 +0200 +++ b/drivers/media/video/msp3400.c 2004-06-17 17:31:21.000000000 +0200 @@ -1556,13 +1556,12 @@ static int msp_command(struct i2c_client /* ----------------------------------------------------------------------- */ -static int msp3400_init_module(void) +static int __init msp3400_init_module(void) { - i2c_add_driver(&driver); - return 0; + return i2c_add_driver(&driver); } -static void msp3400_cleanup_module(void) +static void __exit msp3400_cleanup_module(void) { i2c_del_driver(&driver); }