On Sat, Jun 05, 2004 at 10:27:16AM +0200, Jean Delvare wrote: > Nice catching for TEMP_TO_REG, I completely missed that one. BTW, now > that I took a longer look at it, I really wonder how a negative > temperature limit could ever been set with this. Looks like it'll end up > with 0. OTOH, asking for a temperature higher than 127.5 degrees will > most likely lead to "random" negative values. This is probably true for > both the 2.4 and the 2.6 driver as of now. Could you please test and > confirm? Most likely nobody cares about setting negative limits, but > while we're at cleaning up this part of the driver... Yep, testing (on 2.6) confirms this, fixed it. Btw, "grep SENSORS_LIMIT drivers/i2c/chips/*.c|grep 127" shows that lm85.c has a rounding error in it's TEMP_TO_REG() macro (and probably in at least one other place). > Yes, looks very good to me (except for my comment above about setting > negative temperature limits). Ok, I'll send it to Greg KH then.
