[PATCH 2.6] New chip driver: pcf8591

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 09, 2004 at 09:42:07PM +0200, Jean Delvare wrote:
> 
> BTW, wouldn't a "else return -1" make sense here? Silently ignoring
> errors doesn't sound good to me.

Well make it a real error, like -EINVAL or something, so userspace has a
chance to report it properly.  Not just -1.

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux