On Thu, Apr 01, 2004 at 11:16:36PM +0200, Jean Delvare wrote: > > > Greg, I would be interested in your opinion. Should we update all > > > our chip drivers to have two memory allocations instead of a single > > > one for this? > > > > Yeah, we probably should :( > > OK... Here we go. I've converted all drivers in our CVS repository to a > new model where we do the two kmallocs separately. I didn't commit it > yet because it's a very important change (47 chip drivers affected). So > I'd appreciate code reviews and tests before I apply it. > > The patch is here: > http://jdelvare.net1.nerim.net/sensors/lm_sensors-CVS-separate-mallocs.diff > It applies on latest CVS. > > I tested only the eeprom and lm90 drivers so far. Seems to work, but the > changes are error-prone so what it "seems" is hardly enough to be sure > it's correct. At a quick glance it looks sane. thanks, greg k-h
