Quoting myself:
> While testing, I found a corner case that isn't handled properly. It
> doesn't seem to be handled by the lm78 and the asb100 either. Setting
> fanN_div before ever reading from the chip or setting fanN_min will
> make use of fanN_min while it was never initialized.
The following patch addesses the issue. Tested to work on my AS99127F
rev.1 (which means that only the changes to the w83781d driver were
actually tested). Testers welcome.
Mark, can you confirm it works for your ASB100 as well? Thanks.
Please apply,
Thanks.
diff -ru linux-2.6.5-rc1/drivers/i2c/chips.orig/asb100.c linux-2.6.5-rc1/drivers/i2c/chips/asb100.c
--- linux-2.6.5-rc1/drivers/i2c/chips.orig/asb100.c Tue Mar 16 21:43:43 2004
+++ linux-2.6.5-rc1/drivers/i2c/chips/asb100.c Mon Mar 22 23:05:12 2004
@@ -807,6 +807,11 @@
/* Initialize the chip */
asb100_init_client(new_client);
+ /* A few vars need to be filled upon startup */
+ data->fan_min[0] = asb100_read_value(new_client, ASB100_REG_FAN_MIN(0));
+ data->fan_min[1] = asb100_read_value(new_client, ASB100_REG_FAN_MIN(1));
+ data->fan_min[2] = asb100_read_value(new_client, ASB100_REG_FAN_MIN(2));
+
/* Register sysfs hooks */
device_create_file_in(new_client, 0);
device_create_file_in(new_client, 1);
diff -ru linux-2.6.5-rc1/drivers/i2c/chips.orig/lm78.c linux-2.6.5-rc1/drivers/i2c/chips/lm78.c
--- linux-2.6.5-rc1/drivers/i2c/chips.orig/lm78.c Tue Mar 16 21:43:43 2004
+++ linux-2.6.5-rc1/drivers/i2c/chips/lm78.c Mon Mar 22 23:10:06 2004
@@ -625,6 +625,12 @@
/* Initialize the LM78 chip */
lm78_init_client(new_client);
+ /* A few vars need to be filled upon startup */
+ for (i = 0; i < 3; i++) {
+ data->fan_min[i] = lm78_read_value(new_client,
+ LM78_REG_FAN_MIN(i));
+ }
+
/* Register sysfs hooks */
device_create_file(&new_client->dev, &dev_attr_in0_input);
device_create_file(&new_client->dev, &dev_attr_in0_min);
diff -ru linux-2.6.5-rc1/drivers/i2c/chips.orig/w83781d.c linux-2.6.5-rc1/drivers/i2c/chips/w83781d.c
--- linux-2.6.5-rc1/drivers/i2c/chips.orig/w83781d.c Tue Mar 16 22:34:08 2004
+++ linux-2.6.5-rc1/drivers/i2c/chips/w83781d.c Mon Mar 22 23:09:59 2004
@@ -1252,6 +1252,12 @@
/* Initialize the chip */
w83781d_init_client(new_client);
+ /* A few vars need to be filled upon startup */
+ for (i = 1; i <= 3; i++) {
+ data->fan_min[i - 1] = w83781d_read_value(new_client,
+ W83781D_REG_FAN_MIN(i));
+ }
+
/* Register sysfs hooks */
device_create_file_in(new_client, 0);
if (kind != w83783s && kind != w83697hf)
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
