Hi Takeru, hi Greg,
Sorry that I did not see it before, but I found some glitches in the
patch as I was porting it to our CVS driver.
First of all, the patch leaves all INIT macros untouched. They are not
used anywhere in the driver now, so they should go.
Then:
> + if (reset) {
> + /* Reset all except Watchdog values and last conversion values
> + This sets fan-divs to 2, among others */
> + it87_write_value(client, IT87_REG_CONFIG, 0x80);
> +
No extra line here please.
> + }
> + tmp = (tmp & 0xc0) | 0x2a;
> + it87_write_value(client, IT87_REG_TEMP_ENABLE, tmp);
> + }
> + data->sensor = tmp;
I don't think this is needed. That value will be updated in
it87_update_client, and this function will be called at least once
before you access data->sensor again.
Again, sorry for not noticing it before.
Greg, either apply Takeru's patch and I'll submit an update, or do you
prefer that Takeru resubmits an updated version?
Thanks.
--
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/
