> > BTW, it'd be nice if someone converted these to module_param, too... > (...) > -MODULE_PARM(force, "i"); > +module_param (force, int, 0); > MODULE_PARM_DESC(force, "Forcibly enable the PIIX4. DANGEROUS!"); Two questions for my personal knowledge: 1* What does the final 0 stand for? 2* Aren't we supposed to convert MODULE_PARM_DESC too? There are loads of MODULE_PARM() used in the whole i2c subsystem. If we are supposed to convert them all, let me know, tell me how to do this cleanly (i.e. what to with that third parameter of module_param, and what to do with MODULE_PARM_DESC) and I'll submit a patch. Thanks. -- Jean Delvare http://www.ensicaen.ismra.fr/~delvare/