[PATCH] i2c-sis630 for 2.6.0-test11 get rid of pci init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 16 December 2003 01:46, Mark Studebaker wrote:
> Good question.
>
> We have 5 bus drivers in our package where we've commented out
> pci_module_init()
> because other drivers have claimed the device and prevented ours from
> loading.
> (i810, savage4, via, viapro, voodoo3)

this is not exactly the same.. e.g. for i810 lspci shows SMBus pci device, but 
for sis630 no pci device exists at all and I consider it as a BUG that 
i2c-sis630 will claim any pci device.

>
> It appears that we should do the same thing to some other drivers
> (amd756 for example?).
> It's one thing if we conflict with an ACPI driver that's doing the same
> thing.
> But some completely unrelated driver, hopefully we can coexist.

on my laptop i2c-sis630 and ACPI coexist w/o any problems, because acpi 
doesn't use smbus (not defined in DSDT).
but it would be nice to use acpi api to read/write smbus registers... I will 
look in it.

>
> This is particularly a problem with video chip drivers where there's
> almost always
> a conflict.
>
> I tried doing the same thing to voodoo3 in 2.6 as an experiment.
> It worked but eventually oopsed. In sysfs, things did appear
> under the other PCI device driver. Didn't look into it further at the
> time.
>
> I've seen opinions in the past that if a chip needed two drivers, the
> chip was
> broken, tough. But hopefully that's not the only option.
>
> Greg, can you give us some guidance here? Unless we can bypass
> pci_module_init()
> in 2.6 a lot of the bus drivers are not going to load.
>
> mds
>
> Alexander Malysh wrote:
> > Hello,
> >
> > 2.6.0 kernel (with great sysfs) just shown a bug that is present in the
> > current i2c-sis630 and was discussed before with Mark M. Hoffman
> > (unfortunately w/o any conclusion) that i2c-sis630 is not a pci device
> > driver and has no need to claiming any pci device. This patch removes
> > pci_[init|remove] stuff because i2c-sis630 just needs a few io ports and
> > should not claim pci device.
> >
> > any comments?
> >
> > --
> > Best regards,
> > Dipl.-Ing.
> > Alexander Malysh
> >
> >
> >                        Name: i2c-sis630.patch
> >    i2c-sis630.patch    Type: text/x-diff
> >                    Encoding: quoted-printable
> >
> >    Part 1.2       Type: application/pgp-signature
> >            Description: signature



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux