On Wed, Oct 15, 2003 at 11:05:47AM -0700, Greg KH wrote: > -device_create_file(&client->dev, &dev_attr_in_max##offset); > +device_create_file(&client->dev, &dev_attr_in_max##offset); \ > +} while (0); ^ Did you really want to have that ';' there? It is harmless in current usage, but it may be confusing. Sam