[BK PATCH] i2c driver fixes for 2.6.0-test2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Greg KH <greg at kroah.com> [2003-08-02 09:56:38 -0700]:
> On Sat, Aug 02, 2003 at 09:55:18AM +0200, Jean Delvare wrote:
> > 
> > Greg,
> > 
> > > <nikkne:hotpop.com>:
> > >   o I2C: fix Kconfig info
> > > 
> > > <patrick:dreker.de>:
> > >   o I2C: add ncforce2 i2c bus driver
> > > 
> > > Benjamin Herrenschmidt:
> > >   o I2C: timer clean up for i2c-keywest.c
> > > 
> > > Daniele Bellucci:
> > >   o I2C: fixed a little memory leak in i2c-ali15x3.c
> > > 
> > > Greg Kroah-Hartman:
> > >   o I2C: remove devinitdata marking from i2c-nforce2.c as it's wrong
> > >   o I2C: consolidate the i2c delay functions
> > >   o I2C: minor cleanups to the i2c-nforce2 driver
> > > 
> > > Jan Dittmer:
> > >   o I2C: convert via686a temp_* to milli degree celsius
> > 
> > Does any of these apply to our CVS repository?
> 
> Probably :)
> 
> The memory leak from Daniele is probably needed, and the i2c delay
> cleanup can also be moved there.  I don't think the others really apply

Done, plus most of the nforce2 patch.  This bit though... any particular
reason you didn't just whack all of it?

@@ -345,18 +334,12 @@
 			smbus->base, smbus->base+smbus->size-1, name);
 		return -1;
 	}
-
-	/* TODO: find a better way to find out whether this file is compiled
-	 * with i2c 2.7.0 of earlier
-	 */
-/*#ifdef I2C_HW_SMBUS_AMD8111
+/*
 	smbus->adapter.owner = THIS_MODULE;
-#endif
-
 	smbus->adapter.id = I2C_ALGO_SMBUS | I2C_HW_SMBUS_NFORCE2;
 	smbus->adapter.algo = &smbus_algorithm;
-	smbus->adapter.algo_data = smbus;*/
-
+	smbus->adapter.algo_data = smbus;
+*/

Regards,

-- 
Mark M. Hoffman
mhoffman at lightlink.com



[Index of Archives]     [Linux Kernel]     [Linux Hardware Monitoring]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux