On Tue, Jul 15, 2003 at 08:42:28PM +0200, Christoph Heine wrote: > + while ((dev = pci_find_device(PCI_VENDOR_ID_VIA, PCI_ANY_ID, dev)) != NULL) { > + id = pci_match_device(vt596_ids, dev); > + if(id) > + if(vt596_probe(dev, id) >= 0) > + return 0; > + } > + return -ENODEV; Heh, yes this is the "proper" way to do this on 2.5/2.6 to get the code to build and run, but it's not the "real" fix. It still has the same problems that pci_for_each_dev() has (minus a few race conditions...) thanks, greg k-h