This was marked as spam. -------- Original Message -------- From: - Mon Jun 9 09:21:14 2003 X-UIDL: 3214fc8c8a685167 X-Mozilla-Status: 0001 X-Mozilla-Status2: 10000000 Return-Path: <lm78 at Stimpy.netroedge.com> Received: from Stimpy.netroedge.com (IDENT:root at Stimpy.netroedge.com [206.228.191.3]) by Ren.netroedge.com (8.12.8p1/8.9.1) with ESMTP id h58MRivL018709 for <phil at ren.netroedge.com>; Sun, 8 Jun 2003 15:27:44 -0700 Received: from Stimpy.netroedge.com (IDENT:lm78 at localhost [127.0.0.1]) h58MhcBI024641; Sun, 8 Jun 2003 15:43:38 -0700 Received: (from lm78 at localhost) by Stimpy.netroedge.com (8.12.8p1/8.12.8/Submit) id h58MhaPn024634; Sun, 8 Jun 2003 15:43:36 -0700 Received: from charger.oldcity.dca.net (charger.oldcity.dca.net [207.245.82.76])h58MhWBI024610 for <sensors at stimpy.netroedge.com>; Sun, 8 Jun 2003 15:43:33 -0700 Received: from earth.solarsys.private (adsl-216-158-52-153.cust.oldcity.dca.net [216.158.52.153]) h58MXYp18361; Sun, 8 Jun 2003 18:33:35 -0400 Received: by earth.solarsys.private (Postfix, from userid 1000) id 66DA07DE2; Sun, 8 Jun 2003 18:33:34 -0400 (EDT) Date: Sun, 8 Jun 2003 18:33:34 -0400 From: Mark M. Hoffman <mhoffman at lightlink.com> To: LKML <linux-kernel at vger.kernel.org>, Sensors <sensors at Stimpy.netroedge.com> Cc: Greg KH <greg at kroah.com> Subject: [RFC PATCH] Add lm78 sensor chip support (2.5.70) Message-ID: <20030608223334.GC30962 at earth.solarsys.private> Mail-Followup-To: LKML <linux-kernel at vger.kernel.org>, Sensors <sensors at stimpy.netroedge.com>, Greg KH <greg at kroah.com> Mime-Version: 1.0 X-Security: MIME headers sanitized on Stimpy.netroedge.com See http://www.impsec.org/email-tools/procmail-security.html for details. $Revision: 1.129 $Date: 2001-04-14 20:20:43-07 Content-Type: multipart/mixed; boundary="cNdxnHkX5QqsyA0e" Content-Disposition: inline User-Agent: Mutt/1.4.1i X-SpamBouncer: 1.5 (8/16/02) X-SBRule: Pattern Match (Embedded Script) (Score: 2147483647) X-SBRule: Pattern Match (Other Patterns) (Score: 6587) X-SBClass: Blocked X-Spambayes-Classification: spam; 1.00 Status: RO X-Status: This patch vs. 2.5.70 adds support for LM78, LM78-J, and LM79 sensors chips based on lm_sensors project CVS. This works on one of my boards. I want to draw attention to something I did with this driver by comparing it to it87.c in 2.5.70: > #define IT87_INIT_TEMP_HIGH_1 600 > #define IT87_INIT_TEMP_LOW_1 200 The hardware uses degrees C, and sysfs uses degrees C * 1000. But these #defines are apparently in units of degrees C * 10. This arbitrary intermediate representation bugs me. And given the new 2.5 sysfs standard, it's unnecessary. In this patch for lm78, I rewrote the conversion routines in terms of the sysfs units - getting rid of the intermediate nonsense. If there are no objections, I'm going to start passing patches to do this to the other sensor chip drivers in 2.5 as well. It would be nice to get some help with this too... especially since I don't have all that hardware at hand to test the results. Regards, -- Mark M. Hoffman mhoffman at lightlink.com -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch-lm78.txt Url: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20030609/35f8b19b/attachment.txt
