On Wed, Mar 26, 2003 at 08:43:43PM +0000, Christoph Hellwig wrote: > On Wed, Mar 26, 2003 at 12:26:23PM -0800, Greg KH wrote: > > We should really split these multivalue files up into individual files, > > as sysfs is for single value files. Makes parsing easier too. > > > > Here's a patch for the lm75.c driver that does this. As we are going to > > need a "generic" read and write for the "real" values that the i2c > > drivers use, I added these files to the i2c-proc.c file. > > i2c-proc.c is the wrong place. Please add a i2c-sensor.c file with > helper code for hardware sensors driver (i2c_detect should move over to > there from i2c-proc.c aswell) Oh, I agree. I just threw it there as I was matching up with other functions already in that file. Eventually i2c-proc.c should be deleted, as all of the proc stuff will be gone. I like the idea of i2c-sensor.c for the remaining i2c_detect() function. thanks, greg k-h
