Substitute hard-coded /sys/module path with $SYSFS_MODULE_DIR. It is going to be used even more often in the upcoming selftests. Signed-off-by: Petr Mladek <pmladek@xxxxxxxx> --- tools/testing/selftests/livepatch/functions.sh | 18 ++++++++++-------- .../selftests/livepatch/test-callbacks.sh | 2 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/livepatch/functions.sh b/tools/testing/selftests/livepatch/functions.sh index e5d06fb40233..3f86b89e6ea7 100644 --- a/tools/testing/selftests/livepatch/functions.sh +++ b/tools/testing/selftests/livepatch/functions.sh @@ -6,7 +6,9 @@ MAX_RETRIES=600 RETRY_INTERVAL=".1" # seconds -SYSFS_KERNEL_DIR="/sys/kernel" +SYSFS_DIR="/sys" +SYSFS_KERNEL_DIR="$SYSFS_DIR/kernel" +SYSFS_MODULE_DIR="$SYSFS_DIR/module" SYSFS_KLP_DIR="$SYSFS_KERNEL_DIR/livepatch" SYSFS_DEBUG_DIR="$SYSFS_KERNEL_DIR/debug" SYSFS_KPROBES_DIR="$SYSFS_DEBUG_DIR/kprobes" @@ -160,7 +162,7 @@ function __load_mod() { fi # Wait for module in sysfs ... - loop_until '[[ -e "/sys/module/$mod" ]]' || + loop_until '[[ -e "$SYSFS_MODULE_DIR/$mod" ]]' || die "failed to load module $mod" } @@ -228,7 +230,7 @@ function unload_mod() { local mod="$1" # Wait for module reference count to clear ... - loop_until '[[ $(cat "/sys/module/$mod/refcnt") == "0" ]]' || + loop_until '[[ $(cat "$SYSFS_MODULE_DIR/$mod/refcnt") == "0" ]]' || die "failed to unload module $mod (refcnt)" log "% rmmod $mod" @@ -238,8 +240,8 @@ function unload_mod() { fi # Wait for module in sysfs ... - loop_until '[[ ! -e "/sys/module/$mod" ]]' || - die "failed to unload module $mod (/sys/module)" + loop_until '[[ ! -e "$SYSFS_MODULE_DIR/$mod" ]]' || + die "failed to unload module $mod ($SYSFS_MODULE_DIR)" } # unload_lp(modname) - unload a kernel module with a livepatch @@ -269,11 +271,11 @@ function set_pre_patch_ret { local mod="$1"; shift local ret="$1" - log "% echo $ret > /sys/module/$mod/parameters/pre_patch_ret" - echo "$ret" > /sys/module/"$mod"/parameters/pre_patch_ret + log "% echo $ret > $SYSFS_MODULE_DIR/$mod/parameters/pre_patch_ret" + echo "$ret" > $SYSFS_MODULE_DIR/"$mod"/parameters/pre_patch_ret # Wait for sysfs value to hold ... - loop_until '[[ $(cat "/sys/module/$mod/parameters/pre_patch_ret") == "$ret" ]]' || + loop_until '[[ $(cat "$SYSFS_MODULE_DIR/$mod/parameters/pre_patch_ret") == "$ret" ]]' || die "failed to set pre_patch_ret parameter for $mod module" } diff --git a/tools/testing/selftests/livepatch/test-callbacks.sh b/tools/testing/selftests/livepatch/test-callbacks.sh index 37bbc3fb2780..a65fd860662e 100755 --- a/tools/testing/selftests/livepatch/test-callbacks.sh +++ b/tools/testing/selftests/livepatch/test-callbacks.sh @@ -303,7 +303,7 @@ livepatch: '$MOD_LIVEPATCH': starting patching transition livepatch: '$MOD_LIVEPATCH': completing patching transition $MOD_LIVEPATCH: post_patch_callback: vmlinux livepatch: '$MOD_LIVEPATCH': patching complete -% echo -19 > /sys/module/$MOD_LIVEPATCH/parameters/pre_patch_ret +% echo -19 > $SYSFS_MODULE_DIR/$MOD_LIVEPATCH/parameters/pre_patch_ret % insmod test_modules/$MOD_TARGET.ko livepatch: applying patch '$MOD_LIVEPATCH' to loading module '$MOD_TARGET' $MOD_LIVEPATCH: pre_patch_callback: $MOD_TARGET -> [MODULE_STATE_COMING] Full formed, running module_init -- 2.47.1