> On Oct 24, 2024, at 16:20, Petr Mladek <pmladek@xxxxxxxx> wrote: > > On Thu 2024-10-24 12:43:17, Wardenjohn wrote: >> Add selftest test cases to sysfs attribute 'stack_order'. >> >> Suggested-by: Petr Mladek <pmladek@xxxxxxxx> >> Signed-off-by: Wardenjohn <zhangwarden@xxxxxxxxx> >> --- >> .../testing/selftests/livepatch/test-sysfs.sh | 71 +++++++++++++++++++ >> 1 file changed, 71 insertions(+) >> >> diff --git a/tools/testing/selftests/livepatch/test-sysfs.sh b/tools/testing/selftests/livepatch/test-sysfs.sh >> index 05a14f5a7bfb..718027cc3aba 100755 >> --- a/tools/testing/selftests/livepatch/test-sysfs.sh >> +++ b/tools/testing/selftests/livepatch/test-sysfs.sh >> @@ -5,6 +5,8 @@ >> . $(dirname $0)/functions.sh >> >> MOD_LIVEPATCH=test_klp_livepatch >> +MOD_LIVEPATCH2=test_klp_callbacks_demo >> +MOD_LIVEPATCH3=test_klp_syscall >> >> setup_config >> >> @@ -21,6 +23,8 @@ check_sysfs_rights "$MOD_LIVEPATCH" "force" "--w-------" >> check_sysfs_rights "$MOD_LIVEPATCH" "replace" "-r--r--r--" > > Sigh, you moved it from some reason. My proposed diff added > "stack_order" here between "replace" and "transition" to follow > the alphabetical order. > >> check_sysfs_rights "$MOD_LIVEPATCH" "transition" "-r--r--r--" >> check_sysfs_value "$MOD_LIVEPATCH" "transition" "0" >> +check_sysfs_rights "$MOD_LIVEPATCH" "stack_order" "-r--r--r--" >> +check_sysfs_value "$MOD_LIVEPATCH" "stack_order" "1" >> check_sysfs_rights "$MOD_LIVEPATCH" "vmlinux/patched" "-r--r--r--" >> check_sysfs_value "$MOD_LIVEPATCH" "vmlinux/patched" "1" > > After fixing the alphabetical order: > > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx> > Tested-by: Petr Mladek <pmladek@xxxxxxxx> > > I could fix the ordering when pushing the patch. > > Best Regards, > Petr OK, I use this order just according to the order added to this test case. Didn't consider the alphabetical order. If necessary, I can resent a V3 patch. Best Regards. Wardenjohn.
