On Tue, Sep 03, 2024 at 10:32:00AM -0700, Song Liu wrote: > +++ w/tools/objtool/elf.c > @@ -468,10 +468,8 @@ static void elf_add_symbol(struct elf *elf, > struct symbol *sym) > * > * TODO: is this still true? > */ > -#if 0 > - if (sym->type == STT_NOTYPE && !sym->len) > + if (sym->type == STT_NOTYPE && !sym->len && false) > __sym_remove(sym, &sym->sec->symbol_tree); > -#endif Song, can you explain this change? Was there a warning about __sym_remove() not being used? Not sure how that would be possible since it should be static inline: INTERVAL_TREE_DEFINE(struct symbol, node, unsigned long, __subtree_last, __sym_start, __sym_last, static inline, __sym) ^^^^^^^^^^^^^ -- Josh
