On Mon, Aug 12, 2024 at 09:21:02AM -0700, Song Liu wrote: > Hi folks, > > Do we have more concerns and/or suggestions with this set? If not, > what would be the next step for it? I'm all for simplifying things, and this does just that, however, I'm not the one you need to convince, the folks who added the original hacks should provide their Reviewed-by / Tested-by not just for CONFIG_LTO_CLANG but also given this provides an alternative fix, don't we want to invert the order so we don't regress CONFIG_LTO_CLANG ? And shouldn't the patches also have their respective Fixes tag? Provided the commit logs are extended with Fixes and order is maintained to be able to bisect correctly: Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> Luis
