On Mon, 2024-01-22 at 10:15 -0700, Shuah Khan wrote: > On 1/12/24 10:43, Marcos Paulo de Souza wrote: > > Add TEST_GEN_MODS_DIR variable for kselftests. It can point to > > a directory containing kernel modules that will be used by > > selftest scripts. > > > > The modules are built as external modules for the running kernel. > > As a result they are always binary compatible and the same tests > > can be used for older or newer kernels. > > > > The build requires "kernel-devel" package to be installed. > > For example, in the upstream sources, the rpm devel package > > is produced by "make rpm-pkg" > > > > The modules can be built independently by > > > > make -C tools/testing/selftests/livepatch/ > > > > or they will be automatically built before running the tests via > > > > make -C tools/testing/selftests/livepatch/ run_tests > > > > Note that they are _not_ built when running the standalone > > tests by calling, for example, ./test-state.sh. > > > > Along with TEST_GEN_MODS_DIR, it was necessary to create a new > > install > > rule. INSTALL_MODS_RULE is needed because INSTALL_SINGLE_RULE would > > copy the entire TEST_GEN_MODS_DIR directory to the destination, > > even > > the files created by Kbuild to compile the modules. The new install > > rule copies only the .ko files, as we would expect the gen_tar to > > work. > > > > Reviewed-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx> > > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx> > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx> > > --- > > Documentation/dev-tools/kselftest.rst | 4 ++++ > > tools/testing/selftests/lib.mk | 26 +++++++++++++++++++++- > > ---- > > > Hi Marcos, > > I would like the doc patch and lib.mk patch separate. If lib.mk needs > changes > we don't have to touch the doc patch. Hi Shuah, on patch 2/3 you also said that you would like to have the documentation changes split in the future, and that you picked the changes into a testing branch. Does it also applies to this patch? Do I need to resend the three patches and separate the documentation part into a new one, or can I apply this rationale to future changes to lib.mk? Sorry, I'm confused. Thanks in advance, Marcos > > thanks, > -- Shuah
