On Thu, Jan 26, 2023 at 12:05:02PM -0500, Joe Lawrence wrote: > On 1/26/23 11:35, Petr Mladek wrote: > > > > Josh accepted the idea in the end so we could actually push the entire > > patchset. I am not sure if anyone else would like to review it > > so I going to wait a bit longer. > > > > Resume: > > > > I am going to push the entire patchset the following week (Wednesday?) > > unless anyone asks for more time or finds a problem. > > > > Hi Petr, > > Re docs: patches (3) and (4) change the klp_shadow_* API. There should > be updates (and possibly examples) to > Documentation/livepatch/shadow-vars.rst. I forgot about shadow-vars.rst! This will be added on v3. > > Having this for v1/v2 would have made review a lot easier, though I > understand not wanting to waste cycles on documenting dead ends. That's true. Next time I'll take care of the docs when the API changes. Thanks for the reviews so far! > > -- > Joe >