On Fri, Dec 02, 2022 at 04:05:25PM -0500, Joe Lawrence wrote: > On 12/2/22 3:03 PM, Shuah Khan wrote: > > On 12/2/22 02:25, Petr Mladek wrote: > >> > >> Yes, kABI is not backward compatible. But building the tests > >> modules out-of-tree way would allow to build test modules with > >> different kABI from the same sources. > >> > > > > Okay. This is a solid reason for livepatch modules to live under > > sefltests. Let's capture this in README and the other updates that > > need to be made to it in v3. > > > > One additional benefit, however small, is that I think everyone is > building production livepatches, source based or via kpatch-build, as > out-of-tree modules. (Miroslav/Petr/Marcos please correct me if I'm > wrong about source based.) You're correct. We construct our livepatches source based and build them as out-of-tree modules. > > Having the livepatch selftests live under selftests/ would imply that > new subsystem (build) features would have to support the production > build use case from the get go. Agreed. This change makes the modules to be built as real world livepatches. > > Regards, > > -- > Joe >
