On 11/18/22 12:14 PM, Song Liu wrote: > Hi Petr, > > On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek <pmladek@xxxxxxxx> wrote: >> >> On Thu 2022-09-01 10:12:52, Song Liu wrote: > [...] >>> >>> arch/powerpc/kernel/module_32.c | 10 ++++ >>> arch/powerpc/kernel/module_64.c | 49 +++++++++++++++ >>> arch/s390/kernel/module.c | 8 +++ >>> arch/x86/kernel/module.c | 102 +++++++++++++++++++++++--------- >>> include/linux/moduleloader.h | 7 +++ >>> kernel/livepatch/core.c | 41 ++++++++++++- >> >> First, thanks a lot for working on this. >> >> I can't check or test the powerpc and s390 code easily. >> >> I am going to comment only x86 and generic code. It looks good >> but it needs some changes to improve maintainability. > > Thanks for these comments and suggestions. I will work on them > and send v4. > Hi Song, I'll help with testing the arches (at least ppc64le and s390x, I can only cross-build ppc32). I can either pick up the patches from the list when you post, or if you want to run them through testing first, lmk. Thanks, -- Joe