On Sun, May 29, 2022 at 09:49:44AM -0500, Madhavan T. Venkataraman wrote: > > > On 5/24/22 09:09, Mark Brown wrote: > > On Mon, May 23, 2022 at 07:16:26PM -0500, madvenka@xxxxxxxxxxxxxxxxxxx wrote: > >> From: "Madhavan T. Venkataraman" <madvenka@xxxxxxxxxxxxxxxxxxx> > >> > >> Implement a built-in command called cmd_fpv() that can be invoked as > >> follows: > >> > >> objtool fpv generate file.o > >> > >> The built-in command invokes decode_instructions() to walk each function > >> and decode the instructions of the function. > > > > In commit b51277eb9775ce91 ("objtool: Ditch subcommands") Josh removed > > subcommands so this interface is going to need a rethink. > > Thanks for mentioning this. I will sync my patchset to the latest and send out version 3. Before you do; why are you duplicating lots of validate_branch() ? Why can't you use the regular code to generate ORC data? I'm really not happy about all this.