Re: [PATCH v5 02/13] module: Simple refactor in preparation for split

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v5 02/13] module: Simple refactor in preparation for split
From: Aaron Tomlin <atomlin@xxxxxxxxxx>
Date: Thu, 10 Feb 2022 16:26:26 +0000
Cc: "mcgrof@xxxxxxxxxx" <mcgrof@xxxxxxxxxx>, "cl@xxxxxxxxx" <cl@xxxxxxxxx>, "pmladek@xxxxxxxx" <pmladek@xxxxxxxx>, "mbenes@xxxxxxx" <mbenes@xxxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "jeyu@xxxxxxxxxx" <jeyu@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-modules@xxxxxxxxxxxxxxx" <linux-modules@xxxxxxxxxxxxxxx>, "live-patching@xxxxxxxxxxxxxxx" <live-patching@xxxxxxxxxxxxxxx>, "atomlin@xxxxxxxxxxx" <atomlin@xxxxxxxxxxx>, "ghalat@xxxxxxxxxx" <ghalat@xxxxxxxxxx>, "allen.lkml@xxxxxxxxx" <allen.lkml@xxxxxxxxx>, "void@xxxxxxxxxxxxx" <void@xxxxxxxxxxxxx>, "joe@xxxxxxxxxxx" <joe@xxxxxxxxxxx>, "msuchanek@xxxxxxx" <msuchanek@xxxxxxx>, "oleksandr@xxxxxxxxxxxxxx" <oleksandr@xxxxxxxxxxxxxx>
In-reply-to: <f40fd2b2-2038-a53b-23ec-8f63941a2103@csgroup.eu>

On Thu 2022-02-10 11:18 +0000, Christophe Leroy wrote:
> > +#define MODULE_SECT_READ_SIZE (3 /* "0x", "\n" */ + (BITS_PER_LONG / 4))
>
> This is used only in sysfs.c, why move it to internal.h ?

Agreed. Since use is exclusive to kernel/module/sysfs.c it should be moved.

Kind regards,

-- 
Aaron Tomlin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH v5 00/13] module: core code clean up
  - From: Aaron Tomlin
- [PATCH v5 02/13] module: Simple refactor in preparation for split
  - From: Aaron Tomlin
- Re: [PATCH v5 02/13] module: Simple refactor in preparation for split
  - From: Christophe Leroy

Prev by Date: Re: [PATCH v2] livepatch: Skip livepatch tests if ftrace cannot be configured
Next by Date: Re: [PATCH v5 01/13] module: Move all into module/
Previous by thread: Re: [PATCH v5 02/13] module: Simple refactor in preparation for split
Next by thread: [PATCH v5 03/13] module: Make internal.h more compliant
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux SCSI]