On 2/3/22 05:30, Mark Brown wrote: > On Wed, Feb 02, 2022 at 06:34:43PM -0600, Madhavan T. Venkataraman wrote: >> On 2/2/22 12:46, Mark Brown wrote: >>> On Mon, Jan 17, 2022 at 08:56:03AM -0600, madvenka@xxxxxxxxxxxxxxxxxxx wrote: > >>>> Rename the arguments to unwind() for better consistency. Also, use the >>>> typedef stack_trace_consume_fn for the consume_entry function as it is >>>> already defined in linux/stacktrace.h. > >>> Consistency with...? But otherwise: > >> Naming consistency. E.g., the name consume_entry is used in a lot of places. >> This code used to use fn() instead of consume_entry(). arch_stack_walk() >> names the argument to consume_entry as cookie. This code calls it data >> instead of cookie. That is all. It is minor in nature. But I thought I might >> as well make it conform while I am at it. > > The commit message should probably say some of that then. OK. Will add that to the commit message in the next version. Madhavan
