On 11/30/21 9:08 AM, Mark Rutland wrote: > On Tue, Nov 23, 2021 at 01:37:20PM -0600, madvenka@xxxxxxxxxxxxxxxxxxx wrote: >> From: "Madhavan T. Venkataraman" <madvenka@xxxxxxxxxxxxxxxxxxx> >> >> Rename unwinder functions for consistency and better naming. >> >> - Rename start_backtrace() to unwind_start(). >> - Rename unwind_frame() to unwind_next(). >> - Rename walk_stackframe() to unwind(). > > Super trivial, but could we s/unwind_start/unwind_init/ ? That makes it > slightly clearer that it's not performing an unwind step. > > Otherwise, this looks good to me. > Will do. > For the rename: > > Acked-by: Mark Rutland <mark.rutland@xxxxxxx> > > It's be nice if we could also clean up 'struct stackframe' into 'struct > unwind_state', but that can be a follow-up, and this is fine as it is, modulo > the super trivial comment above. > I could do this rename as well in the next version if you want. Might as well get all the renaming done in one shot. Thanks, Madhavan
