One more thing... > @@ -4379,8 +4379,7 @@ int module_kallsyms_on_each_symbol(int (*fn)(void *, const char *, > unsigned int i; > int ret; > > - module_assert_mutex(); > - > + mutex_lock(&module_mutex); > list_for_each_entry(mod, &modules, list) { > /* We hold module_mutex: no need for rcu_dereference_sched */ > struct mod_kallsyms *kallsyms = mod->kallsyms; This was the last user of module_assert_mutex(), which can be removed now. Miroslav