On 06/14/2017, 03:27 PM, Josh Poimboeuf wrote:
> I agree with all your comments, will fix them all. Thanks for the
> review.
This is not the correct way:
++ if (flags & O_WRONLY)
++ cmd = ELF_C_WRITE;
++ else if (flags & O_RDWR)
++ cmd = ELF_C_RDWR;
++ else
++ cmd = ELF_C_READ_MMAP;
For this particular codeflow, it works, but it should be:
(flags & O_ACCMODE) == O_WRONLY
== O_RDWR
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe live-patching" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
