On Thu, Jun 01, 2017 at 07:36:09AM -0500, Josh Poimboeuf wrote: > On Thu, Jun 01, 2017 at 02:13:56PM +0200, Peter Zijlstra wrote: > > So we do that lookup for every single frame. That's going to hurt. > > > > Would it make sense to cache the last 'module' in an attempt to at least > > avoid that lookup again? Something like so: > > The only thing with caching the module is, what if the module goes away? Yeah.. *boom* ;-) We could of course play games with module_get() and module_put(), but meh. > Based on your previous comment I was thinking I would disable preemption > for the entire unwind_next_frame() step, but not *between* steps. I > suppose we could require the unwind caller to disable preemption but I'd > like to avoid that if possible. Right, keeping it disabled across a frame should be ok I suppose. -- To unsubscribe from this list: send the line "unsubscribe live-patching" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
