On Wed, 8 Mar 2017, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@xxxxxxx>
>
> klp_mutex is shared between core.c and transition.c, and as such would
> rather be properly located in livepatch.h so that we don't have to play
> 'extern' games from .c sources.
>
> This also silences sparse warning (wrongly) suggesting that klp_mutex
> should be defined static.
>
> Signed-off-by: Jiri Kosina <jkosina@xxxxxxx>
> ---
> include/linux/livepatch.h | 2 ++
> kernel/livepatch/transition.c | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h
> index 194991ef9347..4efa89f95dd7 100644
> --- a/include/linux/livepatch.h
> +++ b/include/linux/livepatch.h
> @@ -138,6 +138,8 @@ struct klp_patch {
> func->old_name || func->new_func || func->old_sympos; \
> func++)
>
> +extern struct mutex klp_mutex;
> +
> int klp_register_patch(struct klp_patch *);
> int klp_unregister_patch(struct klp_patch *);
> int klp_enable_patch(struct klp_patch *);
> diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c
> index 0ab7abd53b0b..14f7ce64b002 100644
> --- a/kernel/livepatch/transition.c
> +++ b/kernel/livepatch/transition.c
> @@ -28,8 +28,6 @@
> #define MAX_STACK_ENTRIES 100
> #define STACK_ERR_BUF_SIZE 128
>
> -extern struct mutex klp_mutex;
> -
A nit, but could you also include "linux/livepatch.h" in transition.c to
make the dependency explicit (and not through patch.h or transition.h)?
Anyway, not a big deal and you can add my
Acked-by: Miroslav Benes <mbenes@xxxxxxx>
Miroslav
--
To unsubscribe from this list: send the line "unsubscribe live-patching" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
