On Mon 2016-02-08 13:12:45, Torsten Duwe wrote: > On Mon, Feb 08, 2016 at 11:34:06AM +0100, Petr Mladek wrote: > > On Sat 2016-02-06 11:32:43, Torsten Duwe wrote: > > > On Fri, Feb 05, 2016 at 05:18:34PM +0100, Petr Mladek wrote: > > > [...] > > > > more complicated. Whem I think about it, the change below does similar > > > > job and looks more strightforwad: > > > > > > Had I only looked closer. That's exactly how I thought it would work > > > in the first place. I'd call that a fix. Full ACK from my side. > > > > Feel free to merge this into your patch. Or do you want to do > > this in a separate one, please? > > My Kconfig/Makefile changes depend on it, but OTOH this change (Fix!) > is independent. > > IMHO the right thing would be you resend your second mail from Feb-05, > with your sign-off, my ack, FWIW, and Steven checks it in ;-) Please, find it below. I guess that it should be applied before the check causing the build error. It will help to keep the tree bisectable. >From 2b0fcb678d7720d03f9c9f233b61ed9ed4d420b3 Mon Sep 17 00:00:00 2001 From: Petr Mladek <pmladek@xxxxxxxx> Date: Mon, 8 Feb 2016 16:03:03 +0100 Subject: [PATCH] ftrace: Allow to explicitly disable the build of the dynamic ftrace with regs This patch allows to explicitly disable CONFIG_DYNAMIC_FTRACE_WITH_REGS. We will need to do so on PPC with a broken gcc. This situation will be detected at buildtime and could not be handled by Kbuild automatically. Also it fixes the prompt of DYNAMIC_FTRACE. The uppercase better fits the style of the other menu entries. This patch does not change the default value. Signed-off-by: Petr Mladek <pmladek@xxxxxxxx> Acked-by: Torsten Duwe <duwe@xxxxxx> --- kernel/trace/Kconfig | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index a138f6d866ae..de6dab0f74f2 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -449,7 +449,7 @@ config PROBE_EVENTS def_bool n config DYNAMIC_FTRACE - bool "enable/disable function tracing dynamically" + bool "Enable/Disable function tracing dynamically" depends on FUNCTION_TRACER depends on HAVE_DYNAMIC_FTRACE default y @@ -472,9 +472,17 @@ config DYNAMIC_FTRACE otherwise has native performance as long as no tracing is active. config DYNAMIC_FTRACE_WITH_REGS - def_bool y + bool "Pass registers to function tracer" depends on DYNAMIC_FTRACE depends on HAVE_DYNAMIC_FTRACE_WITH_REGS + default y + help + This option enables passing the current state of processor + registers to the function tracer. It allows to do a more + detailed analyze and print more information. + + Say Y here if you are unsure. The only exception is if + you want to pass a build error caused by a broken compiler. config FUNCTION_PROFILER bool "Kernel function profiler" -- 1.8.5.6 -- To unsubscribe from this list: send the line "unsubscribe live-patching" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
