On Thu 2016-02-04 09:18:01, Steven Rostedt wrote: > On Thu, 4 Feb 2016 14:27:51 +0100 > Petr Mladek <pmladek@xxxxxxxx> wrote: > > > > > + ftrace_module_enable(mod); > > > blocking_notifier_call_chain(&module_notify_list, > > > MODULE_STATE_COMING, mod); > > > return 0; > > > > Also we need to call ftrace_release_mod() in bug_cleanup: > > goto target in load_module(). Otherwise, it will stay > > enabled when, e.g. parse_args() fails. > > Look farther down (after free_module:), it's already there. Ah, I see. ftrace_release_mod() is called there on an unexpected location. Error paths typically do actions in the reverse order in compare with the normal paths :-) Thanks for the pointer, Petr -- To unsubscribe from this list: send the line "unsubscribe live-patching" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
