Re: [PATCH] livepatch: Cleanup page permission changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 3 Nov 2015, Josh Poimboeuf wrote:

> It's probably a good idea to keep the patches bisectable, so I made this
> a separate patch which applies on top of the first one.
> 
> (Note that it completely removes all the code from the first patch, so
> there's no need for a v2 of the first patch which would have had
> Miroslav's suggested style changes.)

I'd go along with Jiri and fold this patch to the first one.

> ---8<---
> 
> Subject: [PATCH] livepatch: Cleanup page permission changes
> 
> Calling set_memory_rw() and set_memory_ro() for every iteration of the
> loop in klp_write_object_relocations() is messy and inefficient.  Change
> all the RO pages to RW before the loop and convert them back to RO after
> the loop.
> 
> Suggested-by: Miroslav Benes <mbenes@xxxxxxx>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>

Great, I like the change.

Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>

Cheers,
Miroslav
--
To unsubscribe from this list: send the line "unsubscribe live-patching" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux