Re: [RFC PATCH 13/21] x86/asm/crypto: Fix frame pointer usage in aesni-intel_asm.S

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 18, 2015 at 04:25:25PM +0200, Borislav Petkov wrote:
> On Sat, Jul 18, 2015 at 08:46:55AM -0500, Josh Poimboeuf wrote:
> > I like the balance, but the "ret" is still non-obvious.
> 
> Does it have to be obvious?

I feel that making "ret" obvious is better.

But if somebody messes up and adds a second "ret", I suppose
stackvalidate would warn about the fact that it returned without
restoring the frame pointer.  So if there are no other objections, your
suggestion of ENTRY_FRAME and ENDPROC_FRAME is fine with me.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe live-patching" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux