On Tue, 14 Jul 2015, Josh Poimboeuf wrote: > Here's another issue [1] which Jessica found. It affects the livepatch > sysfs API, so we should probably fix it soon before we get actual users. > > Here's our current sysfs layout for displaying patched function names: > > /sys/kernel/livepatch/<patch>/<object>/<func> > > A problem occurs when patching two distinct functions which have the > same name: ... and are both built-in. > sysfs: cannot create duplicate filename '/kernel/livepatch/kpatch_s_next_ambig/vmlinux/s_next' > > Does anybody rely on the "func" sysfs entry? Well, our sysfs ABI is documented in testing/, so if worse comes to worst, we should be able to fix it in a backwards incompatible way without being called the bad guys breaking userspace. > I suppose our options are to either remove "func" completely or replace > it with something more unique like the function address. How about extending the attribute to consist of both name and the address. That will automatically provide disambiguation, and would still maintain human readability. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe live-patching" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
