On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote:
> klp_initialized() should return bool but is actually returning
> struct kobject * - convert it to a boolean explicitly.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
Reviewed-by: Jiri Slaby <jslaby@xxxxxxx>
Thanks.
> ---
>
> static code checking was not happy with
> ./kernel/livepatch/core.c:131 WARNING: return of wrong type
> bool != struct kobject *
>
> This adds !! to explicitly convert to boolean type.
>
> Patch was compile tested with x86_64_defconfig
>
> patch is against 4.1-rc2 (localversion-next is -next-20150508)
>
> kernel/livepatch/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index 0e7c23c..c0ae3d8 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -128,7 +128,7 @@ static bool klp_is_patch_registered(struct klp_patch *patch)
>
> static bool klp_initialized(void)
> {
> - return klp_root_kobj;
> + return !!klp_root_kobj;
> }
>
> struct klp_find_arg {
>
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe live-patching" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
