On Tue 2015-03-10 09:22:04, Josh Poimboeuf wrote: > On Tue, Mar 10, 2015 at 01:01:07PM +0100, Petr Mladek wrote: > > On Mon 2015-03-09 09:40:55, Josh Poimboeuf wrote: > > > On Mon, Mar 09, 2015 at 02:25:28PM +0100, Petr Mladek wrote: > > > > diff --git a/kernel/module.c b/kernel/module.c > > > > index d856e96a3cce..b3ffc231ce0d 100644 > > > > --- a/kernel/module.c > > > > +++ b/kernel/module.c > > > > @@ -3271,6 +3271,10 @@ static int load_module(struct load_info *info, const char __user *uargs, > > > > } > > > > #endif > > > > > > > > +#ifdef CONFIG_LIVEPATCH > > > > + mod->klp_alive = false; > > > > +#endif > > > > + > > > > > > I don't think you need this initialization. It looks like the module > > > struct is embedded in the mod->module_core region which is initialized > > > to zero in move_module(). > > > > I have looked at this before but I was not able to find a code > > zeroing struct module. If I get it correctly, mod->module_core > > is a location where symbol table sections are copied or so. > > Yeah, it's far from obvious. AFAICT, it's cleared by the > "memset(ptr, 0, mod->core_size)" line. What I wanted to say is that module_core is not struct module. It seems that it points to the module code. See within_module_core() and how it is used(). By other words, I think that struct module is not zeroed and we need to initialize the bool. Or did I miss anything? Best Regards, Petr -- To unsubscribe from this list: send the line "unsubscribe live-patching" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
